Strip fileno before validating #18497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
API-40166-trim_fileno_bi/main/main
va-vfs-bot
temporarily deployed
to
API-40166-trim_fileno_bi/main/main
va-vfs-bot
temporarily deployed
to
API-40166-trim_fileno_bi/main/main
michelpmcdonald
added
Lighthouse
github-actions
bot
added
require-backend-approval
omit-backend-approval
and removed
require-backend-approval
labels
michelpmcdonald
added
benefits-intake
kristen-brown
requested changes
Sep 19, 2024
github-actions
bot
added
require-backend-approval
test-passing
and removed
omit-backend-approval
test-passing
labels
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
|
@department-of-veterans-affairs/backend-review-group Would y'all be willing to take a peek at this and #18490 ? We feel confident in the changes but have been unable to keep the branch fresh long enough to secure a review and merge. |
va-vfs-bot
temporarily deployed
to
API-40166-trim_fileno_bi/main/main
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
va-vfs-bot
temporarily deployed
to
API-40166-trim_fileno_bi/main/main
github-actions
bot
added
require-backend-approval
ready-for-backend-review
and removed
require-backend-approval
test-passing
labels
stevenjcumming
approved these changes
Oct 3, 2024
|
Backend-review-group approval confirmed. |
github-actions
bot
added
require-backend-approval
test-passing
ready-for-backend-review
and removed
require-backend-approval
test-passing
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Consumers are submitting multipart files with leading and trailing whitespace for the veteran's metadata fileNumber.
They should not be doing this, and we do reject those submissions, but it's easy enough for us to strip and keep on truck'in.
Team banana-peels, we own this code
Related issue(s)
API-40166
Testing done
Unit test add leading and trailing whitespace to fileNumber and confirm that the whitespace is removed and the submission passes our validation
What areas of the site does it impact?
Benefits Intake PDF upload submissions
Acceptance criteria